Hi Luis,

Generally looks good, one comment:

On Tue, 2008-05-20 at 10:56 +0100, Luis de Bethencourt wrote:
> %files
> %defattr (-, root, sys)

Please use (-, root, bin) in %defattr, otherwise this would
make all files in /usr/bin etc owner by sys, which is
unusual.

Thanks,
Laca

> %dir %attr (0755, root, bin) %{_bindir}
> %{_bindir}/*
> %dir %attr(0755, root, bin) %{_mandir}
> %dir %attr(0755, root, bin) %{_mandir}/*
> %{_mandir}/*/*
> %dir %attr (0755, root, sys) %{_datadir}/nano
> %{_datadir}/nano/*
> 


Reply via email to