Hi Laca,

I have submitted a bug on bugzilla and recorded in gamin.spec in JDS trunk.
While Daniel told me he was very busy and had my review request on his 
to-do list. I don't know when he will be available, anyway, I will 
update the bugzilla with my new patch again.

Thanks,
lin

Laszlo (Laca) Peter wrote:
> Lin,
>
> I read on the gamin list that Daniel wanted this patch
> reviewed and split such that you have FEN support and
> general Solaris porting separately and unnecessary
> changes like changing the MAINTAINERS file removed.
>
> It seems to make a lot of sense for 2 reasons:
>  - you have a chance that the patch gets accepted
>    upstream
>  - people can actually review it -- I doubt anyone
>    on this list read through this long patch
>
> Could you do that?
>
> Thanks,
> Laca
>
> On Tue, 2008-03-04 at 16:46 +0800, Lin Ma wrote:
>   
>> The main changes is to not to stat() a missing file.
>>
>> plain text document attachment (gamin-01-all.diff)
>> Index: gamin/MAINTAINERS
>> ===================================================================
>> --- gamin/MAINTAINERS        (revision 0)
>> +++ gamin/MAINTAINERS        (revision 328)
>> @@ -0,0 +1,6 @@
>> +Please see http://www.gnome.org/~veillard/gamin/contacts.html for 
>> +contact informations on this project:
>> +
>> +Daniel Veillard
>> +E-mail: veillard at redhat.com
>> +Userid: veillard
>> Index: gamin/libgamin/fam.h
>> ===================================================================
>> --- gamin/libgamin/fam.h     (revision 325)
>> +++ gamin/libgamin/fam.h     (working copy)
>> @@ -190,6 +190,54 @@
>>  extern int FAMErrno;
>>  
>>  /**
>> + * FAMDebugLevel:
>> + *
>> + * Currently unimplemented as in the SGI FAM.  Exists only for
>> + * compatibility.
>> + */
>> +extern int FAMDebugLevel (FAMConnection *fc,
>> +                      int level);
>> +/**
>> + * FAM_DEBUG_OFF:
>> + * Unused macro, compatibility for SGI FAM API.
>> + */
>> +#define FAM_DEBUG_OFF 0
>> +/**
>> + * FAM_DEBUG_ON:
>> + * Unused macro, compatibility for SGI FAM API.
>> + */
>> +#define FAM_DEBUG_ON  1
>> +/**
>> + * FAM_DEBUG_VERBOSE:
>> + * Unused macro, compatibility for SGI FAM API.
>> + */
>> +#define FAM_DEBUG_VERBOSE 2
>> +
>> +/**
>> + * FAMDebugLevel:
>> + *
>> + * Currently unimplemented as in the SGI FAM.  Exists only for
>> + * compatibility.
>> + */
>> +extern int FAMDebugLevel (FAMConnection *fc,
>> +                      int level);
>> +/**
>> + * FAM_DEBUG_OFF:
>> + * Unused macro, compatibility for SGI FAM API.
>> + */
>> +#define FAM_DEBUG_OFF 0
>> +/**
>> + * FAM_DEBUG_ON:
>> + * Unused macro, compatibility for SGI FAM API.
>> + */
>>     
>
>
>   

-- 
x82120 / +86 10 82618200


Reply via email to