Hi Brian,
I have no problem with adding this, it's certainly not high risk.
Some comments below:
>
> Index: base-specs/gnome-games.spec
> ===================================================================
> --- base-specs/gnome-games.spec (revision 13161)
> +++ base-specs/gnome-games.spec (working copy)
> @@ -75,8 +75,8 @@
> --disable-scrollkeeper \
> --with-libggz-includes=%{libggz_build_dir}/src \
> --with-libggz-libraries=%{libggz_build_dir}/src/.libs \
> - --with-ggzmod-includes=%{ggzmod_build_dir}/ggzmod \
> - --with-ggzmod-libraries=%{ggzmod_build_dir}/ggzmod/.libs \
> + --with-ggzmod-includes=%{ggzclient_build_dir}/ggzmod \
> + --with-ggzmod-libraries=
> %{ggzclient_build_dir}/ggzmod/.libs \
I'm surprised these lines actually work. Normally, if you want to
define macros in the Solaris spec file that you want to use in the
base spec files, you need to do that _before_ the %use line otherwise
it'll be ignored. I have a guess for why it works, but it's more a
bug than a feature. Can you move the definition of these macros
in SUNWgnome-games.spec to the top, before the %use line for
gnome-games.spec please.
>
>
>
>
>
>
> plain text
> document
> attachment
> (ggz-python-02-fixmake.diff)
>
> --- ggz-python-0.0.14.1/po/i18n.mk-orig 2008-02-27 20:10:40.095004000
> -0600
> +++ ggz-python-0.0.14.1/po/i18n.mk 2008-02-27 20:11:30.707160000
> -0600
> @@ -8,6 +8,7 @@ builddir = $(top_builddir)/$(subdir)
> POFILES = $(srcdir)/*.po
> MOFILES = $(builddir)/*.mo
> STAMP = $(builddir)/translation.stamp
> +SHELL= /bin/bash
Couldn't you just use "make SHELL=/bin/bash" instead?
> all-local: $(STAMP)
>
>
>
>
>
>
>
>
>
> plain text
> document
> attachment
> (ggz-python-03-sysconfdir.diff)
>
> --- ggz-python-0.0.14.1/Makefile.in-orig 2008-02-27
> 22:34:15.212831000 -0600
> +++ ggz-python-0.0.14.1/Makefile.in 2008-02-27 22:35:02.171182000
> -0600
> @@ -10,6 +10,8 @@ prefix = @prefix@
> bindir = @bindir@
> # datadir: For game data files (/usr/share)
> datadir = @datadir@
> +# sysconfdir: For game system configuration files (/etc)
> +sysconfdir = @sysconfdir@
Similarly, you could just use "make sysconfdir=%_sysconfdir"
Laca
> # xdg_datadir: For desktop integration files
> (/usr/share/applications)
> xdg_datadir = @xdg_datadir@
> @@ -25,7 +27,6 @@ ggz-config = @GGZ_CONFIG@ -D
>
> # some default autoconf variables
> exec_prefix = ${prefix}
> -sysconfdir = ${prefix}/etc
>
> ggzd_execmoddir = ${prefix}/lib/ggzd
> ggz_execmoddir = ${prefix}/lib/ggz
>
>
