Hi Jim,

A general comment would be that we are shipping a 64-bit version
of gtk+, so we should probably have a 64-bit gtkspell as well,
but then we probably need to have a 64-bit SUNWgnome-spell first.
I suggest you file a bug against both SUNWgnome-spell and gtkspell
so that this won't be forgotten about.

On Fri, 2008-07-04 at 15:06 +0800, Jim Li wrote:

> %if %cc_is_gcc
> %else
> %endif

This doesn't seem very useful.  Since you're setting CXXFLAGS
later, I suspect this package includes C++ code, in which
case you probably want to set CXX to "$CXX -norunpath" in the %else
branch.

> export CFLAGS="%optflags"
> export CPPFLAGS="%optflags"
> export CXXFLAGS="%cxx_optflags"
> export LDFLAGS="%_ldflags"

> ./configure --prefix=%{_prefix} --mandir=%{_mandir} \
>             --libdir=%{_libdir}              \
>             --libexecdir=%{_libexecdir}      \
>             --sysconfdir=%{_sysconfdir} --disable-gtk-doc

we have a macro for enabling/disabling gtk docs, called
%gtk_doc_option.  Normally, gtk docs are enabled by default
and are shipped in the devel package.  Any reason you
disabled it?


> %files devel
> %defattr (-, root, bin)
> #%dir %attr (0755, root, bin) %{_bindir}
> #%{_bindir}/*

Please delete the commented lines.

Thanks,
Laca



Reply via email to