On Tue, 2008-07-08 at 03:45 +1200, Laszlo (Laca) Peter wrote:
> Hi Jeff,
> 
> Comments inline:
> 
> On Mon, 2008-07-07 at 18:28 +0800, Jeff Cai wrote:
> > Index: SUNWgnome-spell.spec
> > ===================================================================
> > --- SUNWgnome-spell.spec        (revision 14488)
> > +++ SUNWgnome-spell.spec        (working copy)
> > @@ -1,7 +1,7 @@
> >  #
> >  # spec file for package SUNWgnome-spell
> >  #
> > -# includes module(s): gnome-spell, enchant
> > +# includes module(s): enchant
> >  #
> >  # Copyright 2007 Sun Microsystems, Inc.
> 
> Please update the year to 2008.
> 
> >  %build
> >  %if %cc_is_gcc
> >  %else
> > @@ -62,16 +76,29 @@
> >  # to $CXX.
> >  export LD=$CXX
> >  export LDFLAGS="%_ldflags"
> > -%enchant.build -d %name-%version
> > +
> > +%ifarch amd64 sparcv9
> > +%enchant_64.build -d %name-%version/%_arch64
> > +%endif
> > +
> > +%enchant.build -d %name-%version/%base_arch
> >  export CFLAGS="%optflags"
> >  export CXXFLAGS="%cxx_optflags"
> >  export PKG_CONFIG_PATH=../enchant-%{enchant.version}:
> > %{_pkg_config_path}
> > -%gspell.build -d %name-%version
> 
> I don't think the above will produce 64-bit binaries, did you
> check that whatever gets installed in /usr/lib/{amd64|sparcv9}
> is really 64-bit?
> 
> The problem is that all the compilation flags are set in the
> Solaris spec and not in the base spec.  So the same flags will
> be used in both invocations on enchant.spec's %build.
> You need to set the ISA specific flags (CFLAGS, CXXFLAGS,
> PKG_CONFIG_PATH) in the base specs.

Laca, 

I changed the enchant spec referring to the spec of libpng. I didn't see
any special flags related with 64 bits platform.

Could you give me an example so that I can change my spec according to
the example?

Or could you summary a guide for desktop engineers which we can follow
to make specs for 64 bits?

Thanks

Jeff
> 
> Laca
> 
> 


Reply via email to