Damien,
Thanks, I updated the spec file, and attached....
Regards,
Henry
Damien Carbery ??:
>> Requires: SUNWcompiz
> Please add BuildRequires: SUNWcompiz-devel
> Also, SUNWcompiz is only built on x86 so then SUNWavant might have to be x86
> only too.
>
>> rm -rf $RPM_BUILD_ROOT
>> mkdir $RPM_BUILD_ROOT
>> export PKG_CONFIG_PATH=%{_prefix}/lib/pkgconfig:%{X11_DIR}/lib/pkgconfig
>>
>> if [ ! `pkg-config --exists x11` ]
>> then
>> cp %{SOURCE1} ${RPM_BUILD_ROOT}
>> export PKG_CONFIG_PATH=${PKG_CONFIG_PATH}:${RPM_BUILD_ROOT}
>> fi
> Instead of copying x11.pc you should require SUNWxwinc (you should add
> BuildRequires: SUNWxwinc).
>
>> export LDFLAGS="-L$PROTO_LIB -L%{X11_DIR}/lib -R%{X11_DIR}/lib"
> Where is $PROTO_LIB set?
>
>> rm -f ${RPM_BUILD_ROOT}%{_libdir}/*.a
>> rm -f ${RPM_BUILD_ROOT}%{_libdir}/*.la
> Please don't use -f - if the .a or .la files are not delivered we will not
> know. Omitting -f means that the build will fail and we will then know that
> the spec file needs to be updated.
>
>> %dir %attr (0755, root, bin) %{_libdir}/python2.4/site-packages
> We install python modules to vendor-packages, not site-packages.
> Add the following to %install:
> # move to vendor-packages
> mkdir -p $RPM_BUILD_ROOT%{_libdir}/python%{pythonver}/vendor-packages
> mv $RPM_BUILD_ROOT%{_libdir}/python%{pythonver}/site-packages/* \
> $RPM_BUILD_ROOT%{_libdir}/python%{pythonver}/vendor-packages/
> rmdir $RPM_BUILD_ROOT%{_libdir}/python%{pythonver}/site-packages
>
>> +++ avant-window-navigator-0.2.6.mod/configure
> You should not modify configure, just configure.in and call autoconf.
>
>> + if test -z "`echo "$CFLAGS" | grep "\-Wall" 2> /dev/null`" ; then
> I have never seen this test. Why is this added?
> The test for $GCC is normally enough (and you have that already).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SUNWavant.spec
Type: text/x-rpm-spec
Size: 4826 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20080718/58f8134b/attachment.bin>
