Please send this alias your patch simply next time as I also asked last year. http://opensolaris.org/os/project/jds/documents/code_review/
To review or not to review: * spec file changes other than adding the Patch / %patch / %changelog entries are subject to review I think the alias is a great opportunity to communicate base/l10n and Sun/none-Sun and don't want to break the process. fujiwara Harry Fu wrote: > Hi, Brian: > > The added source(l10n-configure.sh) is not a new file -- it is already > under ext-sources dir and has been embedded in many other spec files. > > Regards, > Harry > > Brian Cameron wrote: > >> Harry: >> >> When you add a new file as a Source to a spec-file, please include >> the added file as an attachment so we can review it as well. >> >> Thanks, >> >> Brian >> >> >>> To fix CR6643604(gnome/l10n-asia [Vermillion] file-roller displays >>> date modifiers(%-m %-d) in zh_CN locale.), I submitted a patch as >>> bellow. >>> >>> Regards, >>> Harry >>> >>> -bash-3.2$ diff -u file-roller.spec.org file-roller.spec >>> --- file-roller.spec.org Wed Dec 26 10:44:50 2007 >>> +++ file-roller.spec Wed Dec 26 11:08:37 2007 >>> @@ -18,6 +18,7 @@ >>> Summary: An archive manager for GNOME >>> Source: >>> http://ftp.gnome.org/pub/GNOME/sources/file-roller/2.20/%{name}-% >>> >>> {version}.tar.bz2 >>> Source1: %{name}-po-sun-%{po_sun_version}.tar.bz2 >>> +Source2: l10n-configure.sh >>> # date:2003-07-24 type:branding owner:gman >>> Patch1: file-roller-01-menu-entry.diff >>> URL: http://www.gnome.org >>> @@ -55,6 +56,8 @@ >>> %prep >>> %setup -q >>> %if %build_l10n >>> +#bugster 6643604 >>> +sh -x %SOURCE2 --disable-gnu-extensions --disable-sun-linguas >>> bzcat %SOURCE1 | tar xf - >>> cd po-sun; make; cd .. >>> %endif >>> @@ -128,6 +131,8 @@ >>> %{_datadir}/pixmaps/*.png >>> >>> %changelog >>> +* Wed Dec 26 2007 - harry.fu at sun.com >>> +- Add l10n-configure.sh to remove "%-m" and "%-d". Fixes 6643604 >>> * Tue Nov 27 2007 - damien.carbery at sun.com >>> - Bump to 2.20.2. >>> * Fri Oct 19 2007 - damien.carbery at sun.com >> >> > >
