Laca, In fact, gnome-session patch is backport from upstream. Currently it's already on a special branch called new-gnome-session, which will be moved to gnome-session 2.23 soon and go into 2.24. Until then, our patch can be removed.
For ???gnome-panel and gnome-power-manager patch, I'll try to push upstream once gnome-session 2.23 is ready. Metacity patch seems to hard to push GNOME upstream. But HAL is capable to deal with this kind of Xevent. I have asked Solaris HAL and X86 Power Management team to support "suspend" key in next phase. So it will be possibe to remove from JDS too. -Simon On Wed, 2008-04-02 at 17:01 +1300, Laszlo (Laca) Peter wrote: > What's the plan wrt upstreaming these? > > On Wed, 2008-04-02 at 11:56 +0800, simon.zheng at sun.com wrote: > > Some reasons why replacing gnome-sys-suspend. > > > > In JDS, there's 4 scenarios that requires user to confirm with logout > > or shutdown action. > > > > - Clicking buttons in launch menu of gnome-panel > > - Response to user pressing machine power button > > - Response to user pressing suspend key from keyboard > > - Sending XSMP saveyourself request to gnome-session. > > e.g. $gnome-session-save --kill > > > > Currently, they're dealt with 3 different dialogs from gnome-panel, > > gnome-sys-suspend and gnome-session. It's really bad for both user > > experience and authorization checking. > > > > Also, below RFEs require an enhanced dialog. > > > > - CR #6378018 gnome-sys-suspend should offer "logout" and "reboot" > > choices as well > > - CR #6378021 gnome-sys-suspend should not offer "Suspend" if system > > doesn't support it > > - CR #6621991 No restart option seen in GUI > > - CR #6554809 Shutdown option should not appear on non-root Sun Ray > > desktops > > - CR #6409782 gnome-sys-suspend should use PAM for fallback > > authentication > > > > Thanks, > > -Simon > > >
