As you know, this includes two bugs. One is a broken encoding. Another is the modified date is shown as "1970-01-01".
The former should be ok. Now you're referring the later issue. The problem is the modified date is shown as "1970-01-01" in the gtkfilechooser dialog in case the date is two days ago, i.e. not "Today" and "Yesterday". http://bugzilla.gnome.org/attachment.cgi?id=93432&action=view My observation is the cast does not work as expected in list_mtime_data_func() below. localtime_r ((time_t *) &time_mtime, &tm_mtime); This could be resolved when I put the time_t value instead of GtkFileTime then I put this patch. fujiwara Glynn Foster wrote: > Hey, > > This looks like a broken patch to me - why are you converting away from using > GtkFileTime? > > > Glynn > > Takao Fujiwara - Tokyo S/W Center wrote: > >>I'ld like to commit the attached patch. >> >>The problem causes crashs with gtk open dialog on none UTF-8 locales because >>of incorrect encodings. >> >>bugster: 6591502 >>bugzilla: 465380 >>Upstreamed: yes >> >> >>--- spec-files/base-specs/gtk2.spec.orig 2007-10-16 21:59:11.897485000 >>+0900 >>+++ spec-files/base-specs/gtk2.spec 2007-10-16 22:28:09.660343000 +0900 >>@@ -43,6 +43,8 @@ Patch9: gtk+-09-trusted-extensions >> Patch10: gtk+-10-printing-papi-backend.diff >> # date:2007-07-12 bugster:6563388 bugzilla:456137 owner:bewitche type:bug >> Patch11: gtk+-11-null-print.diff >>+# date:2007-10-16 bugster:6591502 bugzilla:465380 owner:fujiwara type:bug >>+Patch12: gtk+-12-g11n-filechooser-date.diff >> BuildRoot: %{_tmppath}/%{name}-%{version}-build >> Docdir: %{_defaultdocdir}/doc >> Autoreqprov: on >>@@ -122,6 +124,7 @@ cd po-sun; make; cd .. >> %patch9 -p1 >> %patch10 -p1 >> %patch11 -p1 >>+%patch12 -p1 >> >> %build >> %ifos linux >>@@ -224,6 +227,8 @@ fi >> %{_mandir}/man3/*.gz >> >> %changelog -n gtk2 >>+* Tue Oct 16 2007 - takao.fujiwara at sun.com >>+- Add gtk+-12-g11n-filechooser-date.diff to fix correct encodings and cast. >> * Wed Sep 19 2007 - brian.cameron at sun.com >> - Fix URL so it can download. >> * Wed Jul 25 2007 - damien.carbery at sun.com >> > >
