Damien Carbery wrote:
> In totem 2.21.0 there are two references to asprintf().
> This function does not appear to be in Solaris.

4508459:        Solaris should have asprintf() and vasprintf() functions

> +#else
> +      newtext = malloc (sizeof (char *) * 2056);
> +      sprintf(newtext, "%s%s", subnode->data, text);
> +#endif

Shouldn't those be snprintf to make sure you don't overflow the buffer
you allocated?   (Also, I heard someone mention on IRC that Erwann had
a more complete asprintf() replacement in his compiz port.)

-- 
        -Alan Coopersmith-           alan.coopersmith at sun.com
         Sun Microsystems, Inc. - X Window System Engineering

Reply via email to