Thanks Brian, I will keep this on my list and will run a test build without this patch once trunk stabilizes (it's quite broken atm).
Laca On Wed, 2007-03-07 at 16:10 +0800, Brian Cameron wrote: > I have an issue with the libbonobo-02-popt.diff patch. This adds -lpopt > to Libs in the bonobo-activation-2.0.pc file. This patch is owned by > Alo, but I just noticed it is probably incorrect. > > The problem is that bonobo-activation does not depend on libpopt. It > probably does not make sense to add -lpopt here if it isn't actually a > dependency of this module. > > I suspect that this patch was added because it fixed various programs > that link against bonobo-activation which also use -lpopt. Probably the > right fix would be to fix the programs that use this pc file to add > popt, if this patch is even necessary? The comments in ChangeLog aren't > clear about why this patch was ever needed and there is no bug number. > > Removing this patch will probably break something in the build, so I > just wanted to highlight that this patch is probably written wrong > and should be redone. Perhaps someone in the release team should > remove the patch and we can see what breaks and fix it a better way? > > Brian
