Without this patch, serial consoles in
virt-manager don't work on Solaris. The
patch has been submitted upstream.
- Dermot
Index: patches/virt-manager-02-serial-console.diff
===================================================================
--- patches/virt-manager-02-serial-console.diff (revision 0)
+++ patches/virt-manager-02-serial-console.diff (revision 0)
@@ -0,0 +1,35 @@
+--- virt-manager-0.3.0-orig/src/virtManager/serialcon.py
2007-01-31 16:03:18.172831000 +0000
++++ virt-manager-0.3.0/src/virtManager/serialcon.py 2007-01-31
17:32:12.083794000 +0000
+@@ -23,6 +23,7 @@
+ import gobject
+ import termios
+ import tty
++import pty
+
+ class vmmSerialConsole:
+ def __init__(self, config, vm):
+@@ -41,9 +42,6 @@
+ self.terminal.set_scrollback_lines(1000)
+ self.terminal.set_audible_bell(False)
+ self.terminal.set_visible_bell(True)
+- # XXX python VTE binding has bug failing to register constants
+- #self.terminal.set_backspace_binding(vte.ERASE_ASCII_BACKSPACE)
+- self.terminal.set_backspace_binding(1)
+
+ self.terminal.connect("commit", self.send_data)
+ self.terminal.show()
+@@ -82,11 +80,11 @@
+ def opentty(self):
+ if self.ptyio != None:
+ self.closetty()
+- pty = self.vm.get_serial_console_tty()
++ ipty = self.vm.get_serial_console_tty()
+
+- if pty == None:
++ if ipty == None:
+ return
+- self.ptyio = os.open(pty, os.O_RDWR | os.O_NONBLOCK | os.O_NOCTTY)
++ self.ptyio = pty.slave_open(ipty)
+ self.ptysrc = gobject.io_add_watch(self.ptyio, gobject.IO_IN |
gobject.IO_ERR | gobject.IO_HUP, self.display_data)
+
+ # Save term settings & set to raw mode
Index: base-specs/virt-manager.spec
===================================================================
--- base-specs/virt-manager.spec (revision 10822)
+++ base-specs/virt-manager.spec (working copy)
@@ -22,12 +22,16 @@
# date:2006-12-08 owner:dermot type:bug bugster:6530450
Patch1: virt-manager-01-build-flags.diff
+# date:2007-03-09 owner:dermot type:bug bugster:6530453
+Patch2: virt-manager-02-serial-console.diff
+
%description
Virtual Machine Manager
%prep
%setup -q -n %name-%version
%patch1 -p1
+%patch2 -p1
%build
@@ -70,6 +74,9 @@
%{_libexecdir}/virt-manager-launch
%changelog
+* Fri Mar 09 2007 - dermot.mccluskey at sun.com
+- added patch 2 for Serial Console on Solaris
+
* Mon Mar 05 2007 - dermot.mccluskey at sun.com
- Bump to ver 0.3.1
