Laca: Yes, I agree this patch should only go into our 2.17 builds.
Brian > Well, if this is a "temporary fix" that gives certain users who > use a "very rare" cdrom drive "some ability" to play audio CDs, > then I don't think we should do this in HEAD and certainly not > in the stable branch. > > Laca > > On Wed, 2007-01-24 at 12:14 +0800, Brian Cameron wrote: >> Laca: >> >>> On Wed, 2007-01-24 at 11:41 +0800, C Wang wrote: >>>> This patch solved this problem while leave the user to switch off the >>>> patch if the CDROM is big endian( very rare ) by setting the >>>> environment >>>> variable CDROM_BYTE_ORDER. >>> Is there a way to detect this automatically? >>> Setting an env variable is not a nice way to control this, I would think >>> that most people probably start sound-juicer from the Launch menu and >>> not from the command line. It's also a new interface that should >>> be ARC-reviewed and documented. >> I agree. This should be viewed as a temporary fix. Unfortunately >> libcdio doesn't give any interface for determining endian-ness of the >> drive. The cdparanoia (a Linux-only library similar to libcdio) does >> have some code, but it isn't well written and uses statistics to >> "guess" the endianness of the drive. Not sure this code is good to >> use here. >> >> Until we have some code to do endianness detection, this at least >> gives users some ability to configure GStreamer so that it will >> work on drives with the problem. >> >> Brian >> >
