Hi Chris,
Looks better (:
A few more comments.
> plain text document attachment (gdesklets.spec)
> #
> # spec file for package gdesklets
> #
> LD_LIBRARY_PATH="%{_libdir}:$LD_LIBRARY_PATH"
I don't think this is needed, it just adds /usr/lib to the library
search path, but it's the default anyway so I don't see the point.
> %install
> make DESTDIR=$RPM_BUILD_ROOT install \
> SITEPREFIX=/dummy VENDORPREFIX=/dummy
You didn't explain what these /dummys are for.
> %files
> %{_datadir}/icon/*/*/*/*
typo: icons
> plain text document attachment (gdesklets-extra.spec)
> #
> # spec file for package gdesklets-extra
> #
This one looks good.
> plain text document attachment (SUNWgnome-desklets.spec)
> #
> # # spec file for package SUNWgnome-desklets
> #
> %build
> export RPM_OPT_FLAGS="$CFLAGS"
CFLAGS is not set by default, so you need to set CFLAGS to %optflags
first.
> %files
> %defattr (-, root, bin)
> %dir %attr (0755, root, bin) %{_bindir}
> %{_bindir}/*
> %dir %attr (0755, root, bin) %{_libdir}
> %{_libdir}/gdesklets
> %dir %attr (0755, root, sys) %{_datadir}
> %dir %attr (0755, root, other) %{_datadir}/applications
> %{_datadir}/applications/*.desktop
> %dir %attr (0755, root, other) %{_datadir}/pixmaps
> %{_datadir}/pixmaps/*
> %dir %attr (0755, root, bin) %{_mandir}
> %{_mandir}/*
> %if %build_l10n
> %files l10n
> %defattr (-, root, bin)
> %dir %attr (0755, root, sys) %{_datadir}
> %attr (-, root, other) %{_datadir}/locale
> %endif
> %dir %attr (0755, root, other) %{_datadir}/icons
> %{_datadir}/icons/*
%files l10n somehow got inserted into %files.
The last 2 lines should be in the %files section.
Leaving a blank line before %if %build_l10n would make
it more readable.
> plain text document attachment (SUNWgnome-desklets-extra.spec)
> #
> # spec file for package SUNWgnome-desklets-extra
> #
looks good.
> plain text document attachment (gdesklets-01-Solaris-support.diff)
I don't think you answered Alan's concerns about parsing the output
of ifconfig and prtconf.
Did you try and find a supported interface for querying that
information?
Thanks,
Laca
