On Fri, 2007-02-09 at 18:26 +0000, Damien Carbery wrote:
> totem 2.17.91 fails because forte doesn't support the 'x...' variable args
> function declaration.
>
> See:
> http://svn.gnome.org/viewcvs/totem/trunk/src/backend/debug.h?rev=3411&view=markup
> the problem line is:
> #define D(x...) g_message (x)
>
> I changed it to:
> #define D(x...) g_message (x)
correction, you changed it to:
#define D(x, ...) gmessage (x)
This is wrong, though. It won't pass the varargs on to gmessage, only
the first argument, so would cause crashes if it was called with e.g.
D("foo: %s", bar)
> and pushed upstream:
> http://bugzilla.gnome.org/attachment.cgi?id=82180&action=view
>
> Is this the best solution? Should I have added a #elif for Solaris? What
> would the #elfi test be?
Looking at the patch, it seems that the correct solution is in the
#ifdef G_HAVE_ISO_VARARGS branch. It should be defined,
/usr/lib/glib-2.0/include/glibconfig.h defines it.
So I suspect some glib header (glib/gmessages.h?) should be
included to fix this.
Laca
