Looks good, thanks. Laca
On Sun, 2007-02-25 at 16:41 +0700, Doug Scott wrote: > Ah whoops, > I forgot to add SUNWdbus-bindings.spec for review.... > Doug > > Laszlo (Laca) Peter wrote: > > Great job! > > > > On Sat, 2007-02-24 at 11:58 +0700, Doug Scott wrote: > > > >>> You need to add patch comments. I'll publish the patch comment > >>> spec later today. In this case it'll be > >>> > >>> #owner:drdoug type:bug date:2007-02-23 bugzilla:xxxx > >>> > > > > I posted the description of the patch comments here: > > http://opensolaris.org/os/project/jds/documents/patch_comments/ > > > > > >> + --with-dbus-daemondir=/usr/lib \ > >> > > > > I've just noticed this, it should be %{_libdir} everywhere. > > I know it was /usr/lib in the original specs, but it was wrong. > > > > Please commit on Tuesday or Wednesday, before the reorg[1]. > > (The next milestone build starts on Monday.[2]) > > > > [1] http://www.opensolaris.org/jive/thread.jspa?threadID=24935&tstart=0 > > [2] The build schedule is now available here: > > http://opensolaris.org/os/project/jds/documents/jds_schedule/ > > > > Thanks, > > Laca > > > > > > plain text document attachment (SUNWdbus-bindings.spec) > # > # spec file for package SUNWdbus-bindings > # > # includes module(s): dbus_glib, dbus_python > # > # Copyright (c) 2005 Sun Microsystems, Inc. > # This file and all modifications and additions to the pristine > # package are under the same license as the package itself. > # > # Owner: yippi > # bugdb: bugzilla.freedesktop.org > # > %include Solaris.inc > > %use dbus_glib = dbus-glib.spec > %use dbus_python = dbus-python.spec > > Name: SUNWdbus-bindings > Summary: Simple IPC library based on messages > Version: %{default_pkg_version} > SUNW_BaseDir: %{_basedir} > BuildRoot: %{_tmppath}/%{name}-%{version}-build > %include default-depend.inc > Requires: SUNWdbus > Requires: SUNWgnome-base-libs > Requires: SUNWlxml > Requires: SUNWxwrtl > Requires: SUNWlexpt > Requires: SUNWPython-extra > BuildRequires: SUNWdbus-devel > BuildRequires: SUNWgnome-base-libs-devel > BuildRequires: SUNWlxml > BuildRequires: SUNWsfwhea > BuildRequires: SUNWPython-extra > > %package devel > Summary: %{summary} - development files > SUNW_BaseDir: %{_basedir} > %include default-depend.inc > Requires: SUNWgnome-base-libs > > %prep > rm -rf %name-%version > mkdir %name-%version > %dbus_glib.prep -d %name-%version > %dbus_python.prep -d %name-%version > > %build > %if %cc_is_gcc > export CFLAGS32="%optflags -I/usr/sfw/include" > export CFLAGS64="%optflags64 -I/usr/sfw/include" > %else > export CFLAGS32="-xc99 -D_REENTRANT %optflags -I/usr/sfw/include > -D__EXTENSIONS__" > export CFLAGS64="-xc99 -D_REENTRANT %optflags64 -I/usr/sfw/include > -D__EXTENSIONS__" > %endif > export RPM_OPT_FLAGS=$CFLAGS > export CFLAGS="${RPM_OPT_FLAGS}" > export LDFLAGS32="%_ldflags -L/usr/sfw/lib -R/usr/sfw/lib -lexpat" > export LDFLAGS64="%_ldflags -L/usr/sfw/lib/%{_arch64} > -R/usr/sfw/lib/%{_arch64} -lexpat" > export LDFLAGS="${LDFLAGS32}" > export PKG_CONFIG_PATH32=../dbus-glib-%{dbus_glib.version}:%{_pkg_config_path} > export > PKG_CONFIG_PATH64=../dbus-glib-%{dbus_glib.version}-64:%{_pkg_config_path64} > export PYTHON=%{_bindir}/python > > # Put /usr/ccs/lib first in the PATH so that cpp is picked up from there > # note: I didn't put /usr/lib in the PATH because there's too much other > # stuff in there > # > export PATH=/usr/ccs/lib:$PATH > > %dbus_glib.build -d %name-%version > PKG_CONFIG_DISABLE_UNINSTALLED= > unset PKG_CONFIG_DISABLE_UNINSTALLED > export PKG_CONFIG_PATH=../dbus-glib-%{dbus_glib.version} > %dbus_python.build -d %name-%version > > %install > rm -rf $RPM_BUILD_ROOT > %dbus_glib.install -d %name-%version > %dbus_python.install -d %name-%version > > %{?pkgbuild_postprocess: %pkgbuild_postprocess -v -c > "%{version}:%{jds_version}:%{name}:$RPM_ARCH:%(date > +%%Y-%%m-%%d):%{support_level}" $RPM_BUILD_ROOT} > > %clean > rm -rf $RPM_BUILD_ROOT > > %if %(test -f /usr/sadm/install/scripts/i.manifest && echo 0 || echo 1) > %iclass manifest -f i.manifest > %endif > > %files > %defattr (-, root, bin) > %dir %attr (0755, root, bin) %{_bindir} > %{_bindir}/* > %dir %attr (0755, root, bin) %{_libdir} > %{_libdir}/lib*.so* > %{_libdir}/python* > %dir %attr (0755, root, sys) %{_datadir} > %{_datadir}/dbus-1 > %ifarch amd64 sparcv9 > %dir %attr (0755, root, bin) %{_libdir}/%{_arch64} > %{_libdir}/%{_arch64}/lib*.so* > %endif > > %files devel > %defattr (-, root, bin) > %dir %attr (0755, root, bin) %{_libdir} > %dir %attr (0755, root, other) %{_libdir}/pkgconfig > %{_libdir}/pkgconfig/* > %dir %attr (0755, root, bin) %{_includedir} > %{_includedir}/* > %dir %attr (0755, root, sys) %{_datadir} > %dir %attr (0755, root, other) %{_datadir}/doc > %{_datadir}/doc/* > %{_datadir}/gtk-doc > %ifarch amd64 sparcv9 > %dir %attr (0755, root, bin) %{_libdir}/%{_arch64} > %dir %attr (0755, root, other) %{_libdir}/%{_arch64}/pkgconfig > %{_libdir}/%{_arch64}/pkgconfig/*.pc > %endif > > %changelog > * Fri Feb 23 2007 - dougs at truemail.co.th > - updated to include 64-bit build RFE: #6480511 > * Fri Jan 26 2007 - damien.carbery at sun.com > - Set PKG_CONFIG vars in %build because dbus-python use autofoo/configure/make > process rather than setup.py. > * Thu Jan 25 2007 - damien.carbery at sun.com > - Add %{_datadir}/doc to devel pkg, because of new dbus-python tarball. > * Thu Dec 21 2006 - brian.cameron at sun.com > - Remove references to SUNWdbus-bindings-root since we do not > build this package. > * Thu Sep 21 2006 - brian.cameron at sun.com > - Created. >
