Hi reviewers, I'ld like to integrate this patch as a feature patch in vermillion build. - This patch is quite useful for users to search multibyte strings in .pdf files which is generated by libgnomeprint - The patch is not so long, just 300 lines - gnome-print-pdf-tt.c and gnome-print-pdf.c have not been updated for two years
bugster: 6347163 bugzilla: 306930 upstreamed: no Are you ok to commit the patch? Thanks, fujiwara -------- Original Message -------- Subject: [jds-review] libgnomeprint patch for pdf search/copy Date: Thu, 26 Apr 2007 11:22:45 -0400 From: Suresh Chandrasekharan <[email protected]> To: jds-review at opensolaris.org This patch is attached to bugzilla for a long while now. Seems like community is not very interested to look into libgnomeprint related issues. bugster : http://monaco.sfbay/detail.jsf?cr=6347163 bugzilla : http://bugzilla.gnome.org/show_bug.cgi?id=306930 Index: ChangeLog =================================================================== RCS file: /cvs/gnome/libgnomeprint/ChangeLog,v retrieving revision 1.640 diff -u -r1.640 ChangeLog --- ChangeLog 10 Nov 2006 09:06:42 -0000 1.640 +++ ChangeLog 13 Feb 2007 22:46:00 -0000 @@ -1,3 +1,37 @@ +2007-02-13 Suresh Chandrasekharan <suresh.chandrasekharan at sun.com> + + Fix for bugzilla # 407648 "PDF output does not support searching" + + * libgnomeprint/gnome-print-pdf-private.h: gnome_print_embed_pdf_font + added an additional glyph2unicode parameter for passing the + glyph-id to unicode mapping array. A new private function + gnome_print_pdf_font_tounicode is also defined, which outputs + "ToUnicode" mapping for a subsetted TrueType font. + + * libgnomeprint/gnome-print-pdf-tt.c: + (gnome_print_pdf_ttsubset_low_glyph_bound): New static function for + calculating the lower glyph bound in an array is defined. + + (gnome_print_pdf_tt_subset_embed): Changed to call + gnome_print_pdf_ttsubset_low_glyph_bound + + (gnome_print_pdf_font_tounicode): New function for output + ToUnicode charmap for a subsetted font. + + * libgnomeprint/gnome-print-pdf.c: + (subsetfontname_cmp): New sort function defined for sorting the + subsetted fonts based on psnames. + + (gnome_print_embed_all_pdf_fonts): Changed to define glyph2unicode + array, which is created only once for all the subfonts of a + masterfont. The pdf font embedding order is changed based on + the masterfont so that we don't have to do the expensive + for loop for all subfonts. + + (gnome_print_embed_pdf_font): Call gnome_print_pdf_font_tounicode + is subsetting is happening, use the returned objet_number as the + the ToUnicode object number. + 2006-11-10 Kjartan Maraas <kmaraas at gnome.org> * NEWS: Update some.
