Stephen: I agree with Alo that we should use AC_PATH_PROG to detect cdrecord-ProDVD rather than just detecting Solaris. It would be easier to get this patch upstream if we code the configure script properly.
A related issue is that cdda2wav does a better job of ripping CD's than any of the GStreamer CDDA plugins. After talking to Joerg Schilling (the maintainer of cdda2wav), it is not likely possible to use the underlying code cdda2wav uses in GStreamer. In summary, this is because cdda2wav uses Uscsi (7I). Here is some background about Uscsi issues that prevent its use in GStreamer. --- Uscsi is a poorly designed, insecure API, its use is strongly discouraged by ARC. E.g. should Rhythmbox call uscsi ioctls directly, it would need to run with elevated privileges via RBAC --- Obviously it would be ugly to write a GSTreamer CDDA plugin which would require any program using the plugin to have elevated permissions via RBAC. That said, it wouldn't be too hard to make programs like sound-juicer simply call cdda2wav rather than using GStreamer to do the extraction. Since cdda2wav does have RBAC settings, we don't have a problem with RBAC if we just call cdda2wav directly. If we have an interest in improving the quality of CD burning (also cdda2wav works with a number of CD drives that don't work with the kernel ioctl techniques used by GStreamer CDDA plugins), then such a project might be worth some time. One disadvantage of using cdda2wav is that it only creates WAV files. So if the sound-juicer user wants to save files in other formats, it might be necessary to then take the created WAV file and convert them to the desired format via a gst-launch command. This would mean the ripping would be slower, but would be of higher quality and would work with more drives. So there are trade offs to consider. I mention this in case someone is interested in working on such a project. Or if people think this is a big value add, then I could dedicate some time to doing this. Brian > cdrecord is a command line util for burning cds and dvds, however dvd > burning is not supported in all versions of cdrecord shipped on > different OS platforms, therefore nautilus-cd-burner will resort to > using growisofs for burning DVDs. > > Solaris cdrecord-ProDVD DOES support dvd burning for all users but > does not support non root dvd burning with growisofs so burning of dvds > on Solaris fails even though it has better support than other OS's using > cdrecord :) > > This patch conditionally returns FALSE for all *needs_growisofs* tests > and burns dvds in the same way as cds using cdrecord. > > Stephen. >
