Rick,
I don't remember seeing a code review for this spec file.
Anyhow, some comments. I really dislike the package name.
Everyone, please consult jds-re before introducing new package
names. But I've just checked the ARC FT (LSARC/2006/685)
and it says
4.4. Packaging & Delivery:
GAIM OTR will be shipped as a part of GAIM in SUNWgnome-im-client
package.
SUNWgnome-im-client (base package) - application i.e binary,
libraries
SUNWgnome-im-client-share (share package) - desktop file, icons,
bonobo server files, man
pages and help files.
SUNWgnome-im-client-l10n (localization) - Localization.
The pkgmap entry will be:
1 f none lib/gaim/libotr.so 0755 root other # # #
This project will deliver into Solaris 11 and Solaris 10 Update 4.
Thus the project is requesting a Minor release binding and a
Patch release binding.
I'm fine with this packaging, although SUNWgnome-im-client-l10n
need not be mentioned in any ARC material as we're not delivering
it to anywhere. The *-l10n packages are only used for creating
the SUNWgnome-l10nmessages-* and SUNWgnome-l10ndocuments-* packages.
So please remove this spec file and submit a review for updating
SUNWgnome-im-client.spec.
> ERROR: SUNWgnome-gaim-otr: Source file
> http://www.cypherpunks.ca/otr/gaim-otr-3.0.0.tar.gz not found
Oh, and you forgot to submit the tarball for the RE builds.
Thanks,
Laca
