Laca:

> Since /tmp is shared, I suggest you include the user name and maybe
> even the date/time in the file name to avoid clashes.  You should also
> check if tar returned an error.
> 
> In the message at the end, it would be nice to tell the users where
> to go for filing bugs (d.o.o?) and a warning that these files may
> include sensitive information.

Is this patch better.  I think it addresses your concerns.  For
example it now creates files like:

/tmp/gnome-cleanup-username-2009-01-15-17:01:53.tar

If so, should this just go into spec-files SVN head or also to the
stable branch?

Brian
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cleanup.diff
URL: 
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20090115/69d3d5dc/attachment.ksh>

Reply via email to