Please also update trunk. I'd like to maintain SUN_BRANDING comments for trunk only.
Thanks, fujiwara Erwann Chenede-san wrote (01/11/09 12:50 AM): > Hi All, > The attached diff file present a diff from the previous version > of the > nautilus time-slider patch. This is the easiest way I found to present > the changes. > > All these changes will be integrated in build 107. > > This patch addresses the following issues : > - 6765590 [time slider need a snapshot now feature] and 6765592 [time > slider need destroy current snapshot feature] > These feature allow to create and destroy snapshot via a UI. > Either by clicking on an icon in the time-slider bar > or using the context menu item associated with a directory while > browsing directories. > once selected time-slider-delete or time-slider-snapshot is called. > > For this new feature I've implemented a polling mechanism to > update the current > set of zfs snapshots being browsed as the .zfs does support FEN > yet. (see monitor* function) > This fixes d.o.o bugs 5486 [Time Slider causes Nautilus to core > when a snapshot is deleted while Time Slider is active] > and 5488 [Time Slider doesn't update to include snapshots newly > created while the slider is active]. > Now when a change is detected the snapshot list is refreshed and > the slider is moved right to available snapshot is > the current snapshot being browsed has been destroyed (see > slider_moved_callback fct for details). > > - 5932 [nautilus time-slider UI (time-bar) should be disabled by > clicking on the time-slider-symbo again] > Now the restore button is enabled not only in snapshotted > directory but also when browsing snapshots. > See changes in nautilus_zfs_set_snap fct. > > - 6782054 [Time slider gets confused about the path it should be > viewing] > This bug is a side effect of the old snapshot retrieval > information algorithm. > This algorithm has been rewritten to be more efficient (e.g. on a > system with 40000 snapshots retrieving > the snapshots associated with a given directory takes around 3 sec > instead of 30 min !) > This has been achieved by optimizing ts_get_snapshots_for_dir > function : > - by avoiding traversing all the snapshot for nested zfs filesystem. > - only recursing into filesystems instead of children (see > zfs_callback) > - testing for the existence of the snapshot before trying > iterating through it. > - UI enhancement, the slider bar information as been > modified to display information in a more user friendly > manner. > > Thanks, > > Erwann > > > > I'm attaching a diff from the previous version of the nautilus time > > slider patch for ease of reading. > > > > > >
