Hi,
thie review request is to fix:
http://defect.opensolaris.org/bz/show_bug.cgi?id=4327
The problem is that resizing and/or rotating the panel produces horrible
looking
results as the background image doesn't resize and/or rotate in response to
the panel, ruining the desired semi opaque effect of the panel.
The fix is to preconfigure the default panel layout to "fit" and rotate
the panel
background image by default. Note that there are 2 options to resize the
image,
either "fit" or "stretch". Fit is more appropriate in this instance
since the image
is seamless when tiled horizontally so it doesn't require horizontal
resizing that
a stretch would perform.
Thanks.
Niall.
Here is the diff relative to gnome-panel-01-default-setup-indiana.diff:
--- panel-default-setup.entries.old 2009-01-28 15:07:23.121614004 +0000
+++ panel-default-setup.entries.new 2009-01-28 15:08:43.390247788 +0000
@@ -142,9 +142,17 @@
<string>/usr/share/gnome-panel/pixmaps/top-panel-image.png</string>
</value>
</entry>
-
<entry><key>toplevels/top_panel/background/fit</key><schema_key>/schemas/apps/panel/toplevels/background/fit</schema_key></entry>
+
<entry><key>toplevels/top_panel/background/fit</key><schema_key>/schemas/apps/panel/toplevels/background/fit</schema_key>
+ <value>
+ <bool>true</bool>
+ </value>
+ </entry>
<entry><key>toplevels/top_panel/background/stretch</key><schema_key>/schemas/apps/panel/toplevels/background/stretch</schema_key></entry>
-
<entry><key>toplevels/top_panel/background/rotate</key><schema_key>/schemas/apps/panel/toplevels/background/rotate</schema_key></entry>
+
<entry><key>toplevels/top_panel/background/rotate</key><schema_key>/schemas/apps/panel/toplevels/background/rotate</schema_key>
+ <value>
+ <bool>true</bool>
+ </value>
+ </entry>
<!-- Bottom Panel -->
@@ -208,9 +216,17 @@
<string>/usr/share/gnome-panel/pixmaps/bottom-panel-image.png</string>
</value>
</entry>
-
<entry><key>toplevels/bottom_panel/background/fit</key><schema_key>/schemas/apps/panel/toplevels/background/fit</schema_key></entry>
+
<entry><key>toplevels/bottom_panel/background/fit</key><schema_key>/schemas/apps/panel/toplevels/background/fit</schema_key>
+ <value>
+ <bool>true</bool>
+ </value>
+ </entry>
<entry><key>toplevels/bottom_panel/background/stretch</key><schema_key>/schemas/apps/panel/toplevels/background/stretch</schema_key></entry>
-
<entry><key>toplevels/bottom_panel/background/rotate</key><schema_key>/schemas/apps/panel/toplevels/background/rotate</schema_key></entry>
+
<entry><key>toplevels/bottom_panel/background/rotate</key><schema_key>/schemas/apps/panel/toplevels/background/rotate</schema_key>
+ <value>
+ <bool>true</bool>
+ </value>
+ </entry>
<!-- Menu Bar -->
