Hi,

CR description:
"trying to assign SunPowerSwitch to 'lock Screen'
(launch->Preferences->Keyboard Shortcuts)

The value for "Lock Screen " is well assigned to 'SunPowerSwithc' but hitting 
the key 
launch the "shutdown system" popup".

The fix relates to metacity and gnome-setting-daemon. Currently
SunPowerSwitch key is hardcoded in metacity by a internal patch
metacity-04-sunpowerswitch-key.diff. To make the key configurable, we
just need to remove the patch and let gnome-setting-daemon handles
shutdown dialog which is activated by SunPowerSwitch key currently.

The patch removes metacity-04-sunpowerswitch-key.diff,
gnome-settings-daemon-02-logout-shortcut.diff and creates a new patch
gnome-settings-daemon-02-sleep-action.diff to let gnome-setting-daemon
handles the shutdown dialog.

It removes metacity-06-logout-shortcut.diff too. because when writing
the patch, I find that gnome-settings-daemon-02-logout-shortcut.diff
disables logout keybinding and lets metacity handle it with
metacity-06-logout-shortcut.diff. I disabled the patch, followed
instructions in CR5101706 and can not reproduce the bug.

The patch also updates metacity-08-trusted-extensions.diff and reorder
the others to fix the build. 

The problem about my patch is that it does not map SunPowerSwitch to the
shutdown dialog by default as we do now. Because some users complain
that SunPowerSwitch is easy to be pressed by mistake and the default
60s??? timeout to shutdown is not very user-friendly. Please refer to
CR6767868 for more information.

I also suspect that gnome-settings-daemon-03-custom-keybinding.diff is
not needed anymore but I am not sure. So let Darren decide it.

Regards,

Jedy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 4982 bytes
Desc: not available
URL: 
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20081108/32d39fbe/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gnome-settings-daemon-02-sleep-action.diff
Type: text/x-patch
Size: 1425 bytes
Desc: not available
URL: 
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20081108/32d39fbe/attachment-0001.bin>

Reply via email to