Jerry,
In general, you need include copyright and manpage for this review.
> %define name pigment
> %define version 0.3.11
>
> %include Solaris.inc
>
> Summary: Pigment user interface library with embedded multimedia
> Name: SUNWlib%{name}
You do not need %define name above, use pigment directly.
> License: LGPL v2.1
> Version: %{version}
> URL: https://core.fluendo.com/pigment/trac
> Source0:
> http://elisa.fluendo.com/static/download/pigment/pigment-%{version}.tar.bz2
> SUNW_BaseDir: %{_basedir}
> SUNW_Copyright: %{name}.copyright
> BuildRoot: %{_tmppath}/%{name}-%{version}-build
>
> aclocal $ACLOCAL_FLAGS -I ./common/m4
> gtkdocize
> autoheader
> automake -a -c -f
> autoconf
> ./configure --prefix=%{_prefix} --mandir=%{_mandir} \
> --libdir=%{_libdir} \
> --libexecdir=%{_libexecdir} \
> --sysconfdir=%{_sysconfdir}
> gmake
Any reason using 'gmake' here.
> plain text document attachment (SUNWlibpigment-python.spec)
> #
> # spec file for package SUNWpigment-python
> #
> # includes module(s): pigment-python
> #
> # Copyright 2008 Sun Microsystems, Inc.
> # This file and all modifications and additions to the pristine
> # package are under the same license as the package itself.
> #
> # Owner:jerrytan
> #
> %define name pigment-python
> %define version 0.3.8
> %define pythonver 2.4
>
> %include Solaris.inc
>
> Summary: Python interfaces for pigment
> Name: SUNWlib%{name}
Same as comment #2.
You may need call this package SUNWlibpigment-python24 and add a new for
SUNWlibpigment-python25 for python2.5 binding.
>
> aclocal $ACLOCAL_FLAGS
> autoheader
> automake -a -c -f
> autoconf
> ./configure --prefix=%{_prefix} --mandir=%{_mandir} \
> --libdir=%{_libdir} \
> --libexecdir=%{_libexecdir} \
> --sysconfdir=%{_sysconfdir}
> gmake
Same with comment #3.
