Laca:
Thanks, updated spec files attached.
Brian
> A few comments below.
>
> On Mon, 2008-11-24 at 17:55 -0600, Brian Cameron wrote:
>
>>
>>
>>
>>
>>
>> plain text
>> document
>> attachment
>> (SUNWpython25-simplejson.spec)
>>
>> #
>> # spec file for package SUNWpython25-simplejson
>> #
>> # includes module(s): simplejson
>> #
>
>> Name: SUNW-python25-simplejson
>
> Please remove the extra - after SUNW
>
>> Summary: JSON (Java Script Object Notation)
>> encoder/decoder for Python 2.5
>> URL: %{simplejson.url}
>> Version: %{simplejson.version}
>> SUNW_BaseDir: %{_basedir}
>> SUNW_Copyright: SUNWpython-simplejson.copyright
>> BuildRoot: %{_tmppath}/%{name}-%{version}-build
>>
>> %include default-depend.inc
>> Requires: SUNWPython25
>> BuildRequires: SUNWPython-devel
>
> Should be SUNWPython25-devel
>
>> %prep
>> rm -rf %name-%version
>> mkdir -p %name-%version
>> %simplejson.prep -d %name-%version
>>
>> %build
>> export PYTHON="/usr/bin/python2.5"
>
> It's nicer to use /usr/bin/python%{pythonver}
> Makes it easier to update to 2.6 in the future.
>
>
>>
>>
>>
>>
>>
>> plain text
>> document
>> attachment
>> (SUNWpython-simplejson.spec)
>>
>> #
>> # spec file for package SUNWpython-simplejson
>> #
>> # includes module(s): simplejson
>> #
>
>> Name: SUNW-python-simplejson
>
> Again, there's an extra - after SUNW, please remove.
>
>> Summary: JSON (Java Script Object Notation)
>> encoder/decoder for Python 2.4
>> URL: %{simplejson.url}
>> Version: %{simplejson.version}
>> SUNW_BaseDir: %{_basedir}
>> SUNW_Copyright: SUNWpython-simplejson.copyright
>> BuildRoot: %{_tmppath}/%{name}-%{version}-build
>>
>> %include default-depend.inc
>> Requires: SUNWPython
>> BuildRequires: SUNWPython-devel
>>
>> %prep
>> rm -rf %name-%version
>> mkdir -p %name-%version
>> %simplejson.prep -d %name-%version
>>
>> %build
>> %simplejson.build -d %name-%version
>
> The 2.5 spec file sets a few env variables before this line, do
> you need them here as well?
>
> Laca
>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: SUNWpython25-simplejson.spec
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20081124/f47788be/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: SUNWpython-simplejson.spec
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20081124/f47788be/attachment-0001.ksh>
