Brian Cameron wrote: > > Jim: > >> Attached spec-file, copyright file, and 3 patches are added to >> gnome-2-24 branch and trunk for libvisual and libvisual-plugins. >> >> Please help me to review them. > > I think we also need to modify other spec files to depend on libvisual, > such as SUNWgnome-media-player, and SUNWgnome-media-center. No? Sure. We need to add BuildRequires: SUNWlibvisual in SUNWgnome-media.spec in order to build SUNWgnome-media with libvisual support ( build gstreamer's libvisual plugins). SUNWgnome-media-player and SUNWgnome-media-center all indirectly use libvisual through gstreamer's libvisual plugins.
We should go through all process and get QA's test result before we do this modification. I've built SUNWgnome-media with libvisual support and give it to QA team for testing. > > I built SUNWlibvisual and then SUNWgnome-media-center, and then played > an audio file in elisa, but I didn't see the visual effects. Is there > something we need to do to make sure that elisa builds with libvisual? > I also notice that totem doesn't seem to immediately work with the > libvisual plugins so work may be needed there as well. No? > It'll work if you just build SUNWgnome-media.spec after SUNWlibvisual and reinstall it. Thanks Jim > >
