Brian, Your new patch looks good for me.
-Halton. On Wed, 2008-12-03 at 15:09 -0600, Brian Cameron wrote: > Ghee: This regression was caused by my fix to the SMF integration > used by GDM on 2008-11-21. > > Halton: > > Thanks for he help looking into this. > > I do see that I am getting the "Couldn't find property group" > error message when using OpenSolaris in the logfile: > /var/svc/log/application-graphical-login-gdm:default.log. > However, this was not causing any real serious failure on OpenSolaris since > /bin/sh on OpenSolaris is smarter than on Nevada. > > I recommend using the attached patch instead of the one you proposed > earlier. Your patch works around the shell script failing. However, this > patch fixes the gdm.xml file so it properly defines the properties which are > used in the svc-gdm file. This is really the root problem. > > I tested rebuilding GDM with this patch, rebooting and it works fine. > I went ahead and committed the fix to spec-files. > > Brian > > > [resend it again, sorry for forget attach patch in last email] > > Hi, > > > > This patch is to fix 6779574 - gdm can not start on vermillion_stable > > b105. Since it is a potential stopper bug, I'd like to commit it > > into trunk and gnome-2-24 branch both. > > > > Thanks, > > Halton. > > > > > > > plain text document attachment (gdm.diff) > Index: svc-gdm > =================================================================== > --- svc-gdm (revision 16798) > +++ svc-gdm (working copy) > @@ -18,14 +18,13 @@ > > case "$1" in > 'start') > + FMRI=svc:/application/graphical-login/gdm:default > > - FMRI=svc:application/graphical-login/gdm > - > debug=`svcprop -p gdm/debug $FMRI` > > arg=`eval "echo \`svcprop -p gdm/args $FMRI\`"` > > - if [ $debug = "true" ]; then > + if [ "x$debug" = "xtrue" ]; then > /usr/sbin/gdm $arg --debug > else > /usr/sbin/gdm $arg > Index: gdm.xml > =================================================================== > --- gdm.xml (revision 16798) > +++ gdm.xml (working copy) > @@ -22,12 +22,12 @@ > <service_fmri value='svc:/system/filesystem/local'/> > </dependency> > > - <dependency name='multi-user' > - grouping='require_all' > - restart_on='error' > - type='service'> > - <service_fmri value='svc:/milestone/multi-user:default'/> > - </dependency> > + <dependency name='multi-user' > + grouping='require_all' > + restart_on='error' > + type='service'> > + <service_fmri value='svc:/milestone/multi-user:default'/> > + </dependency> > > <dependency > name='sysconfig' > @@ -80,6 +80,12 @@ > value='solaris.smf.manage.dt.login' /> > </property_group> > > + <!-- these are passed to gdm in the method script --> > + <property_group name='gdm' type='application'> > + <propval name='debug' type='boolean' value='false' /> > + <propval name='args' type='astring' value='' /> > + </property_group> > + > <instance name='default' enabled='false' /> > > <stability value='Unstable' /> >
