I have updated the spec file to remove items based on your comments. I have also added a License field and bumped the version to 1.2.7. This allowed me to reduce the number of patches from 4 to 1.
I have attached the new version of the spec file. Padraig Laszlo (Laca) Peter wrote: > Hi Padraig, > > On Tue, 2008-08-05 at 11:51 +0100, Padraig O'Briain wrote: > >> %if %option_with_gnu_iconv >> Requires: SUNWgnu-libiconv >> Requires: SUNWgnu-gettext >> %else >> Requires: SUNWuiu8 >> %endif >> > > The %option_with_gnu_iconv conditions aren't needed anymore -- > we no longer use GNU iconv on Indiana. You can basically delete > this entire block. > > >> export PYTHON="/usr/bin/python" >> > > Should be /usr/bin/python2.4 > > >> export CFLAGS="%optflags -I/usr/sfw/include -I/usr/gnu/include -DANSICPP" >> > > I doubt it uses anything from /usr/sfw (although not impossible). > It's almost empty now. > > "-DANSICPP" was copied and pasted from spec file to spec file for > no good reason, should be deleted. > > >> %if %option_with_gnu_iconv >> export CFLAGS="$CFLAGS -I/usr/gnu/include -L/usr/gnu/lib -R/usr/gnu/lib >> -lintl" >> %endif >> > > Again, this is not needed anymore. > > >> export CPPFLAGS="-I/usr/sfw/include" >> export LDFLAGS="-L/usr/sfw/lib -R/usr/sfw/lib -L/usr/gnu/lib -R/usr/gnu/lib" >> > > Same comments for /usr/sfw as before. > > Laca > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080806/f57ff636/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: SUNWgnome-commander.spec Type: text/x-rpm-spec Size: 4363 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080806/f57ff636/attachment.bin>
