Rick,

If the specs are new, you'd better give original specs instead of patch format.

Here comes some comments based on your spec.

+# Copyright (c) 2006 Sun Microsystems, Inc.
Should be "Copyright 2008 Sun Microsystems, Inc." in SUNWncurses.spec and 
ncurses.spec.


In SUNWncurses.spec
+%files devel
+%defattr (-, root, bin)
+%dir %attr (0755, root, bin) %{_libdir}
+%{_libdir}/*.a
+%dir %attr (0755, root, bin) %{_includedir}
+%{_includedir}/*

*.a and *.la should be shipped. 
You can refer tsclient.spec, %install part

In ncurses.spec

+glib-gettextize -f
+libtoolize --force
+aclocal $ACLOCAL_FLAGS -I .
+#autoheader
+#automake -a -c -f
+#autoconf
Any intent not run autoheader, automake and autoconf?

+
+CFLAGS="$RPM_OPT_FLAGS -DG_IMPLEMENT_INLINES -DG_HAVE_ISO_VARARGS" \
+LD_LIBRARY_PATH="%{_libdir}:$LD_LIBRARY_PATH"
I can not see any use for add %{_libdir} to $LD_LIBRARY_PATH

+./configure                            \
+       --prefix=%{_prefix}             \
+       --mandir=%{_mandir}             \
+       --sysconfdir=%{_sysconfdir} \
+  --with-normal \
+  --with-shared \
+  --without-debug
Use %debug_build to control it. Refer to tsclient.spec.

+%install
+make DESTDIR=$RPM_BUILD_ROOT install \
+    SITEPREFIX=/dummy VENDORPREFIX=/dummy PERLPREFIX=/dummy
+rm -rf $RPM_BUILD_ROOT%{_datadir}/man
You'll add manpage in SGML format later, right?

-Halton.





Reply via email to