Brian, I removed my changes to the source because what I need can be done in gdm theme. So no patch is needed to putback to the community. I will update the gdm theme of OpenSolaris which is maintained by ourself.
Regards, Jedy On Tue, 2008-08-26 at 10:34 -0500, Brian Cameron wrote: > Jedy: > > > I removed the code which uses a image as the background during login. > > This is the third time I have reviewed this patch, and the third time > that I have the following comment: > > ---- > > If you could also make the patch more backwards compatible, then it > could go upstream. > > To do this just modify the setup_background function so it calls > setup_background_color when the bg_type is not IMAGE or IMAGE_AND_COLOR > and when either GDM_KEY_GRAPHICAL_THEMED_COLOR or > GDM_KEY_BACKGROUND_COLOR is set, similar to the old logic. > > In other words, this could be done in the function setup_background > if image == NULL at the end of the current function. > > ---- > > Looking at the latest patch, it doesn't seem this was done. > > Could you make the code changes to gui/greeter/greeter.c more backwards > compatible? If you could, then this change could go upstream into > GDM 2.20 branch. Wouldn't it be better to get this change upstream > so we only have to patch the configuration file? > > Brian
