Hi Jedy, I'd like to modified your patches slightly. The patches are attached.
I still want the i18n logic likes the attachment. One concern is that "Condensed" style is ok for the latin scripts but DejaVu also includes other scripts, e.g. Arabic. Currently I think the "DejaVu Sans Condensed" may be changed to "DejaVu Sans" for a few locales when we'll get more evaluations in the future and then this i18n is needed. However the patch changes "Sans" to "Sans Condensed" for almost locales to follow the specs. fujiwara Jedy Wang-san wrote (08/27/08 12:24 PM): > Hi Takao, > > The new patch is attached. > > Regards, > > Jedy > On Tue, 2008-08-26 at 16:18 +0900, Takao Fujiwara - Tokyo S/W Center > wrote: >> Jedy Wang-san wrote (08/26/08 02:59 PM): >>> This works. But if the user select Sans Regular again, he can not select >>> Sans Condensed back. So What I want to add Condensed and Book style to >>> Sans font. >> I think you have two options for this. >> >> #1. Fix fontconfig to be able to include "DejaVu Sans Condensed" when "Sans >> Regular" is choosed. >> Currently the preferred families can be specified in fonts.conf but the >> preferred styles cannot be specified. >> Probably I think a patch is needed for libfontconfig.so to be able to >> specify a new style, e.g. >> >> /etc/fonts/conf.d/60-latin.conf >> <family>sans-serif</family> >> <prefer> >> <family>DejaVu Sans<style>Condensed</style></family> >> </prefer> >> </alias> >> >> >> #2 Fix gnome-appearance-properties to be able to show "Condensed" and "Book" >> style with Sans/Serif/Monospace fonts. >> Probably I think it's an enhancement of gnome-appearance-properties(gtk or >> pango?) as I don't see the codes with details. >> >>>> But font families need to be handled in fonts.conf. >>> What do you mean by "handle"? Please be more specific, I am not familiar >>> with font stuff. >> I mean the latin fonts are managed in /etc/fonts/conf.d/*-latin.conf. >> If you need to show a specific font family by default, the *-latin.conf >> files need to be updated. >> AFAIK, "DejaVu Sans" font has been already shown for latin fonts when >> "Sans", "Serif" or "Monospace" is choosed so I think this request is done. >> >> fujiwara >> >>> Regards, >>> >>> Jedy >>>> fujiwara >>>> >>>>> I do not know if this is doable. >>>>> >>>>> Regards, >>>>> >>>>> Jedy >>>>> On Mon, 2008-08-25 at 18:20 +0900, Takao Fujiwara - Tokyo S/W Center >>>>> wrote: >>>>>> Jedy Wang-san wrote (08/25/08 02:44 PM): >>>>>>> The CR6740289 was assigned back by Alan. Could you please add your >>>>>>> comments to the CR? >>>>>> --- /etc/fonts/fonts.conf.orig 2008-08-25 18:03:48.356303000 +0900 >>>>>> +++ /etc/fonts/fonts.conf 2008-08-25 18:09:06.533313000 +0900 >>>>>> @@ -459,4 +459,12 @@ >>>>>> <bool>false</bool> >>>>>> </edit> >>>>>> </match> >>>>>> +<match target="pattern"> >>>>>> + <test name="family"> >>>>>> + <string>DejaVu Sans</string> >>>>>> + </test> >>>>>> + <edit name="style" mode="assign"> >>>>>> + <string>Condensed</string> >>>>>> + </edit> >>>>>> +</match> >>>>>> </fontconfig> >>>>>> >>>>>> Does this change satisfy your request? >>>>>> >>>>>> fujiwara >>>>>> >>>>>>> Regards, >>>>>>> >>>>>>> Jedy >>>>>>> On Fri, 2008-08-22 at 19:27 +0900, Takao Fujiwara - Tokyo S/W Center >>>>>>> wrote: >>>>>>>> Thanks much for the update. >>>>>>>> >>>>>>>> I'm a bit busy now. >>>>>>>> Please let me reply next Monday. >>>>>>>> >>>>>>>> fujiwara >>>>>>>> >>>>>>>> Jedy Wang-san wrote (08/22/08 05:50 PM): >>>>>>>>> I update the patch. Now only font size is changed and the change works >>>>>>>>> for both Nevada and OpenSolaris. I also file a bug(6740289) to >>>>>>>>> fontconfig to update the default font. >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> >>>>>>>>> Jedy >>>>>>>>> On Mon, 2008-08-18 at 16:41 +0900, Takao Fujiwara - Tokyo S/W Center >>>>>>>>> wrote: >>>>>>>>>> I don't think your fix works for locales. >>>>>>>>>> Please change C locale only. >>>>>>>>>> >>>>>>>>>> <default>Sans 10</default> >>>>>>>>>> <locale name="C"> >>>>>>>>>> + <default>DejaVu Sans Semi-Condensed 8</default> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> fujiawra >>>>>>>>>> >>>>>>>>>> Jedy Wang-san wrote (08/18/08 04:23 PM): >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> The attached patches update default fonts of GNOME for OpenSolaris >>>>>>>>>>> 2008.11 according to UI spec. >>>>>>>>>>> --------------------------------------------->8 >>>>>>>>>>> Application font: Deja Vu Sans Condensed 8pt >>>>>>>>>>> Document font: Deja Vu Sans Condensed 8 pt >>>>>>>>>>> Desktop font: Deja Vu Sans Book 8 pt (Book is easier to read against >>>>>>>>>>> background patterns as it has a better drop-shadow) >>>>>>>>>>> Window title font: Deja Vu Sans Bold 8 pt >>>>>>>>>>> Monospace font: Deja Vu Mono Book 8pt >>>>>>>>>>> ---------------------------------------------->8 >>>>>>>>>>> >>>>>>>>>>> font-1.diff will be merged into libgnome-02-indiana-default.diff. >>>>>>>>>>> font-3.diff will be merged into >>>>>>>>>>> nautilus-09-interface-changes-indiana.diff >>>>>>>>>>> metacity-12-opensolaris-branding.diff is a new patch. Actually, >>>>>>>>>>> there is >>>>>>>>>>> a existing patch indexed by 12() but it is not referenced by the >>>>>>>>>>> spec >>>>>>>>>>> file. So I think it can be removed but I will contact Erwann to make >>>>>>>>>>> sure. >>>>>>>>>>> >>>>>>>>>>> Regards, >>>>>>>>>>> >>>>>>>>>>> Jedy >>>>>>>>>>> >>> -------------- next part -------------- A non-text attachment was scrubbed... Name: nautilus-09-interface-changes.diff.diff Type: text/x-patch Size: 1317 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080827/ec1e3c1e/attachment.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: nautilus-09-interface-changes-indiana.diff.diff Type: text/x-patch Size: 1302 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080827/ec1e3c1e/attachment-0001.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: libgnome-01-sun-default-background.diff.diff Type: text/x-patch Size: 2000 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080827/ec1e3c1e/attachment-0002.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: libgnome-02-indiana-default.diff.diff Type: text/x-patch Size: 1845 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080827/ec1e3c1e/attachment-0003.bin>
