Note that in updating gnome-session to 2.19.3, two patches no longer
apply. I wasn't able to figure out how to rework these. So
gnome-session-01-busy-cursor.diff, owned by Erwann and
gnome-session-02-solaris-branding.diff owned by Niall will need some
attention. I'm cc:ing them.
GTK+ patch:
The problem seems to be that the following events are happening:
1. _gtk_tooltip_handle_event is being called for the splash window
because the mouse is hovering over it since it is in the center of
the screen and the mouse is over it by default. This causes
gtk_tooltip_start_delay to be called, which sets up the
tooltip_popup_timeout function to be called.
2. The splash window is destroyed
3. The timeout function is being called and calls
gtk_tooltip_show_tooltip. This calls gdk_window_get_origin on the
window. This function checks to make sure the window argument
passed in is a GDK_WINDOW. However, this test fails. I think
because in 2.19 that warnings are fatal, this causes the crash.
The attached patch fixes this problem by checking if the windows
ref_count is less than 1 and avoids processing the tooltip logic
further if the object has been destroyed.
gnome-session patch:
The new version of gnome-session calls "date +%s" in the Makefile
and since Solaris doesn't support %s, this causes the compile to
fail.
The code has a function gsm_check_time which is used to determine
if the time on the system is not less than the compile time, then
it tries to determine if time-admin should be called for the user.
This hack to just make the function always return TRUE is just a
hack to get the code to compile. I submitted bugzilla bug
#444670 to try to work out a better solution.
Brian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gtk+-14-fixtooltip.diff
Type: text/x-patch
Size: 572 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20070606/de2f2c04/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gnome-session-08-fixtime.diff
Type: text/x-patch
Size: 383 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20070606/de2f2c04/attachment-0001.bin>
