Hey Jedy, Most of this patch didn't actually need a review - it was just a simple update to the version of the spec, and and some url changes.
Can you rationalize why you're removing the common-lisp directory? What does it contain, and why we might be advised to remove it? Glynn Jedy Wang wrote: > Hi all, > > Please review the patch. > > Regards, > > Jedy Wang > > > ------------------------------------------------------------------------ > > Index: Solaris/extra-specs/libgpg-error.spec > =================================================================== > --- Solaris/extra-specs/libgpg-error.spec (revision 9565) > +++ Solaris/extra-specs/libgpg-error.spec (working copy) > @@ -3,7 +3,7 @@ > # > > Name: libgpg-error > -Version: 1.3 > +Version: 1.4 > Release: 1 > Summary: libgpg-error - Common error codes for GnuPG, Libgcrypt etc. > License: GPL, Other License(s), see package > @@ -11,7 +11,7 @@ > Copyright: LGPL > Autoreqprov: on > URL: http://www.gnupg.org/ > -Source: > ftp://ftp.gnupg.org/gcrypt/libgpg-error/%{name}-%{version}.tar.gz > +Source: > http://ftp.gnupg.org/gcrypt/libgpg-error/%{name}-%{version}.tar.gz > Source1: l10n-configure.sh > BuildRoot: %{_tmppath}/%{name}-%{version}-build > > Index: Solaris/extra-specs/libgcrypt.spec > =================================================================== > --- Solaris/extra-specs/libgcrypt.spec (revision 9565) > +++ Solaris/extra-specs/libgcrypt.spec (working copy) > @@ -12,14 +12,14 @@ > # usedforbuild aaa_base acl attr bash bind9-utils bison cpio cpp > cyrus-sasl db devs diffutils e2fsprogs file filesystem fileutils fillup > findutils flex gawk gdbm-devel glibc glibc-devel glibc-locale gpm grep groff > gzip kbd less libgcc libstdc++ libxcrypt m4 make man mktemp modutils ncurses > ncurses-devel net-tools netcfg pam pam-devel pam-modules patch permissions ps > rcs readline sed sendmail sh-utils shadow strace syslogd sysvinit tar texinfo > textutils timezone unitedlinux-release unzip util-linux vim zlib-devel > autoconf automake binutils bzip2 cracklib gcc gdbm gettext libpth libtool > perl rpm zlib > > Name: libgcrypt > -Version: 1.2.2 > +Version: 1.2.3 > Release: 1 > Summary: libgcrypt - The GNU crypto library > License: GPL, Other License(s), see package > Group: Development/Libraries/C and C++ > Autoreqprov: on > URL: http://www.gnupg.org/ > -Source: ftp://ftp.gnupg.org/gcrypt/libgcrypt/%{name}-%{version}.tar.bz2 > +Source: > http://ftp.gnupg.org/gcrypt/libgcrypt/%{name}-%{version}.tar.bz2 > Source1: l10n-configure.sh > BuildRoot: %{_tmppath}/%{name}-%{version}-build > > Index: Solaris/SUNWlibgpg-error.spec > =================================================================== > --- Solaris/SUNWlibgpg-error.spec (revision 9565) > +++ Solaris/SUNWlibgpg-error.spec (working copy) > @@ -49,6 +49,8 @@ > #remove this file because SUNWgnome-base-libs deliver same file > rm $RPM_BUILD_ROOT%{_libdir}/charset.alias > > +rm -rf $RPM_BUILD_ROOT%{_datadir}/common-lisp > + > %if %build_l10n > %else > # REMOVE l10n FILES
