Hi Glynn, I think that this is a good example of the information people should be providing in a review request. Others should follow a similar format.
Is this bug so critical that it requires a patch in JDS SVN before the fix has been accepted in the master source? You only opened the bugzilla bug today and it is still open. Granted it does look like your fix will be accepted but is it possible we can live without this fix until a new source tarball is avilable? In this case there would be no need for a patch and no need for a review here. If not, would it not still be better to wait until your fix has been accpeted before adding another JDS SVN patch? Stephen. On Tue, 2006-10-24 at 13:22 +1300, Glynn Foster wrote: > Hey, > > Though not technically required for a review, here's a patch to gnome-pilot > which fixes part of the following bug - > > 6437924:[multihead] applet preferences/windows launching on wrong head > > And upstream bugzilla - > > http://bugzilla.gnome.org/show_bug.cgi?id=364589 > > Adds a gtk_window_set_screen call so that the about and preference dialogs get > displayed on the correct screen in a multi-screen environment. Moreover, it > improves the current display in the 'Add to panel' dialog by adding a better > icon, localized name and description strings, and better window icons. > > This patch could be extended by porting the module away from gnome_window_* > and > the use of icon themes, but I didn't think we'd gain much by doing that. > Interested readers may like to pick up that challenge separately. > > > Glynn
