Jeff Cai wrote:
> On Wed, 2006-10-25 at 10:23 +0100, Damien Carbery wrote:
>> > +rm -rf $RPM_BUILD_ROOT%{_bindir}/psktool
>> > rm -rf $RPM_BUILD_ROOT%{_datadir}/man
>> > rm -rf $RPM_BUILD_ROOT%{_datadir}/info
>> 1) I would like to see '-rf' switches removed so that we know when these
>> directories/files have been moved or removed and we can then update the
>> spec file.
>> 2) You say that "we do not use it (psktool) now". Is it a problem to
>> leave that file in the package? Maybe someone else will need that file.\
>
> Because psktool is a new tool imported by gnutls. It still doesn't exist
> in gnome 2.16. So removing it will not effect other modules or
> applications. Evolution doesn't want to ship it. I agree to remove it.
My suggestion to leave it in is to 'future proof' the package i.e. if a
module needs the file (it could be a 3rd party application) then it will
be available without asking us to change the package.
We cannot predict who will need this file.
I have no idea what this file does so I cannot decide if it likely that
another module will need it. I am trying to think of unusual circumstances.
If it is to be removed then include a comment like this:
"- Omit psktool as it is not in GNOME and not used by Evolution, the
primary customer of this package."
Do know allow my opinions block your opinion - you know this module
better than I do.
Damien
