Hey,

It's a little hard reviewing diffs of diffs in general so you'd be better off
diff'ing just the code changes - you might want to keep that in mind for the
future.

In general -

> +diff -u gnome-system-tools-2.14.0/src/users/users.desktop.in.in-orig 
> gnome-system-tools-2.14.0/src/users/users.desktop.in.in
> +--- gnome-system-tools-2.14.0/src/users/users.desktop.in.in-orig     
> 2006-01-30 22:18:46.000000000 +0000
> ++++ gnome-system-tools-2.14.0/src/users/users.desktop.in.in  2006-10-23 
> 15:31:55.934923000 +0100
> +@@ -2,7 +2,7 @@
> + _Name=Users and Groups
> + _Comment=Add or remove users and groups
> + Exec=users-admin
> +-ic...@pixmapsdir@/users.png
> ++Icon=users.png
> + Terminal=false
> + Type=Application
> + Categories=GNOME;GTK;Application;System;Settings;

Shouldn't have the file extension, since it would disallow the icon theme from
using an .svg I think. So

Icon=users

should be a better option.


Glynn

Reply via email to