Glynn,
As I just found out, my patch cannot apply because my patch depends on
old version of gnome-panel-08-launch-menu.diff. As you changed this
patch yesterday and removed function panel_menu_button_reload_menus, my
patch failed.
Now I create an updated patch to add that function back to my patch.
Please have a review.
Thanks!
Harry
On Thu, 2006-11-16 at 14:17 +0800, Harry Lu wrote:
> > Okay, I should have clarified - I know what they do, but not quite sure how
> > they
> > do having done a quick grep last night for various code bits in the patch.
> > Doesn't seem to make sense with the current 2.16.x tarballs, so that's why
> > a bit
> > more investigation was needed.
> >
>
> Glynn,
>
> My patches are based on GNOME 2.15.x tarballs just before the GNOME
> 2.16 release. And as I just tested, it works fine on Vermillion Devel
> build 53 which is GNOME 2.16.1.
>
> Why do you say "Doesn't seem to make sense with the current 2.16.x
> tarballs"? We can have a talk about this patches this afternoon in #jds
> IRC.
>
> Thanks,
> Harry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gnome-panel-14-support-alacarte.diff
Type: text/x-patch
Size: 1300 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20061116/7648f580/attachment.bin>
