Hi all,

Does anyone know why we should copy class action scripts into 
ext-sources? Is JDS consolidation allowed to do like this? To me, it 
seems a *pkgbuild* bug. If no other reasons, pkgbuild should directly 
consume the system default class action scripts 
/usr/sadm/install/scripts/* rather than copy them to ext-sources, right?

lin

Laszlo (Laca) Peter wrote:
> Hi Darren, looks good.  Yes, ext-sources is the right place for exec_attr
> and the class action scripts.  Just 2 nits:
>
> On Fri, 2006-11-17 at 22:12 +0000, Darren Kenny wrote:
>   
>>  mkdir %name-%version
>>  %systemtoolsbackends.prep -d %name-%version
>>  %gnomesystemtools.prep -d %name-%version
>> +cp %SOURCE1 %{_builddir}/%name-%version/exec_attr
>>     
>
> You don't actually need to do this (although it doesn't hurt), you
> could just refer to %SOURCE1 in %install.
>
>   
>>  cd %{_builddir}/%name-%version
>>  gzcat %SOURCE0 | tar xf -
>>  
>> @@ -85,6 +87,8 @@
>>  rm -rf $RPM_BUILD_ROOT
>>  %systemtoolsbackends.install -d %name-%version
>>  %gnomesystemtools.install -d %name-%version
>> +mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/security
>> +cp %{_builddir}/%name-%version/exec_attr 
>> $RPM_BUILD_ROOT%{_sysconfdir}/security
>>     
>
> It's usually better to use "install" for this, so that you can specify
> the permissions.
>
> Thanks,
> Laca
>
>   
>>  mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/inet/gnome-system-tools
>>  #Manpages
>>  rm -rf $RPM_BUILD_ROOT%{_mandir} 
>>     
>
>   

-- 
x82120 / +86 10 82618200


Reply via email to