Henry,
Please see my comments below.
Harry
On Mon, 2006-11-20 at 10:27 +0800, Henry Zhang wrote:
> I commited 2 patches, both are tested by myself..
>
> 1. fix for 6484279:
> This bug is to set a value to combo, which is created by glade. The
> value is the default group used to add new user...
>
> +
> + element = g_list_first (groups_list);
> +
> + while ((element != NULL) && (strcmp (element->data, "other") != 0)) {
Does the "other" above need to be translated?
> + element = element->next;
> + counter++;
> + }
> + gtk_combo_box_set_active (GTK_COMBO_BOX (gst_dialog_get_widget
> (tool->main_dialog, "user_settings_group")), counter);
Is counter initialized to 0 somewhere before? And if you cannot find
"other", it will set the first item to be the default. Is this the
expected behavior?
Harry
