Laszlo (Laca) Peter ??: > Hi Henry, > > On Sun, 2006-11-26 at 11:56 +0800, Henry Zhang wrote: > >> diff -Nrup libgtop-2.14.4/include/glibtop/procstate.h >> libgtop-2.14.4.mod/include/glibtop/procstate.h >> --- libgtop-2.14.4/include/glibtop/procstate.h 2006-09-11 >> 05:53:29.000000000 +0800 >> +++ libgtop-2.14.4.mod/include/glibtop/procstate.h 2006-11-25 >> 23:20:40.952117000 +0800 >> @@ -66,11 +66,17 @@ struct _glibtop_proc_state >> * fields if their values are corrent ! */ >> int uid; /* UID of process */ >> int gid; /* GID of process */ >> - int ruid; >> - int rgid; >> - int has_cpu; >> - int processor; >> - int last_processor; >> + int ruid; >> + int rgid; >> + int has_cpu; >> + int processor; >> + int last_processor; >> + >> + gint32 nice; /*zhua: used to store nice */ >> + guint64 start_time; /* start time of process -- */ >> + guint64 vsize; /* number of pages of virtual memory ... */ >> + guint64 resident; /* number of resident set */ >> + guint load; /* cpu load for process */ >> }; >> > > You're changing a header that is included in the -devel pkg here, > i.e. you're changing the API, this should be discussed with the > community maintainer. > I will discuss with the maintainer, this change also will give app. run at Linux some benefit on performance. In fact this change only add some new entries to structure, and will not impact the existed codes,
> Also, it seems that the upstream code uses standard C types and not > glib's g* types. > in libgtop, there are lots of g* types of data, and when I putback the patch to community, they are requiring to use gnome function instead of standard C. > Laca > > >
