Brian:

> The attachment is the new SUNWpython26-coherence.spec after removing 
> SUNWpython24-coherence.spec.
> To remove SUNWpython24-coherence.spec, we need to:
> 
> 1. Copy codes that needed by coherence from SUNWpython24-cohernece.spec 
> to SUNWpython26-coherence.spec
> 2. Rename all "SUNWpython24-coherence" string in manpages/Makefile to 
> "SUNWpython26-coherence"
> 
> I've tested the new spec in my environment.
> If there is anything else needs to be changed, please let me know.

Some comments:

1) We should remove commented-out lines like the following:

    #rm -rf $RPM_BUILD_ROOT%{_bindir}

2) We should not rename the coherence binary.  I assume we won't deliver
    the 2.4 packages, but if we did, we should only do such renaming in
    the 2.4 package.

    mv $RPM_BUILD_ROOT%{_bindir}/coherence
    $RPM_BUILD_ROOT%{_bindir}/coherence2.6

    So the above line should be removed.

3) The 2.4 spec-file had these lines:

    %dir %attr(0755, root, bin) %{_mandir}
    %dir %attr(0755, root, bin) %{_mandir}/*
    %{_mandir}/*/*

    Your new 2.6 spec-file has these lines:

    %dir %attr(0755, root, bin) %{_mandir}/*
    %{_mandir}/*/*

    I think the way in the 2.4 spec-file is better.

Aside from these minor changes, I think the new spec-files looks good,
and you can commit after making these changes.

Thanks,

Brian

Reply via email to