Fu: > Yes, I did testing by checking the background color of xclock and xterm, > and it turns to white after the fix is applied. > According to my test, GNOME can not be started with the indentation > inserted to the last "EOF" line. After I remove it I can login.
Then it's good we tested. I'd update the patch to fix those indentations, and I think this should be fine. Brian > Best Regards, > Harry Fu > Brian Cameron wrote: >> >> Fu: >> >> Did you test to verify that this works properly? >> >> I notice that you added indentation below (a space before the settings). >> Does this work properly when redirecting via EOF? >> >> So, it would be good to test and verify that this fixes bug #6876923. >> Did you check that when you log into GNOME or something else that the >> window colors, etc. are set properly to different values? >> >> Brian >> >> >>> +if [ "$GDMSESSION" = "gnome" ] ; then >>> + $XRDB -merge << EOF >>> + ! Default CDE resources >>> + *WindowColor: #8A008A008A00 >>> + !*WindowForeground: #FF0000000000 >>> + !*DataBackground: #0000FF000000 >>> + *DataForeground: #FF0000000000 >>> + *WorkspaceColor: #8A008A008A00 >>> + *Color.Background: #FF000000FF00 >>> + !*Color.Foreground: #0000FF000000 >>> + *foreground: #000000000000 >>> + ! Hack for Dtmail >>> + *XmText*background: seashell >>> + *XmTextField*background: seashell >>> + *Message_List*background: seashell >>> + *background: #AE00B200C300 >>> + Dthello*string: Welcome to the Sun Java Desktop System >>> EOF >
