On Tue, 2009-10-20 at 16:51 +0800, Halton Huo wrote:
> [SUNWseahorse-plugins.spec]
> > %install
> > rm -rf $RPM_BUILD_ROOT
> > %sp.install -d %name-%version
> > find $RPM_BUILD_ROOT -type f -name "*.la" -exec rm -f {} ';'
> > find $RPM_BUILD_ROOT -type f -name "*.a" -exec rm -f {} ';'
> I prefer to remove ".a" and ".la" in base spec.
> 
> [seahorse-plugins.spec]
> > CFLAGS="$RPM_OPT_FLAGS -I/usr/include/glib-2.0
> >  -I/usr/lib/glib-2.0/include"     \
> Why hard code glib header path here, should this module run pkg-config
> to get it?
Thanks.

These should be removed.

Jeff

> 
> 


Reply via email to