Hi Peter,
Thanks for the review. I will remove the commented dependencies. Next
time I will just send the diffs :-)
All the code is in C++. Should I set CXXFLAGS like this:
%if %cc_is_gcc
%else
export CXX="${CXX} -norunpath"
%endif
export CXXFLAGS="%cxx_optflags"
./configure --prefix=/usr
Mark
Laszlo (Laca) Peter wrote:
> Mark,
>
> We usually send svn diffs for review, it's easier to see
> what you changed in the file.
>
> Since you sent the whole file ;) some questions:
>
> On Wed, 2009-10-28 at 10:50 -0700, Mark Logan wrote:
>
>
>> %include default-depend.inc
>> Requires: SUNWparted
>> #Requires: SUNWglib2
>> Requires: SUNWgtkmm
>> Requires: SUNWglibmm
>> #Requires: SUNWgtk2
>> Requires: SUNWpangomm
>> Requires: SUNWcairomm
>> Requires: SUNWsigcpp
>> #Requires: SUNWlibatk
>> #Requires: SUNWpango
>> Requires: SUNWmlibl
>> Requires: SUNWlibmsr
>> Requires: SUNWxwplt
>> Requires: SUNWxorg-clientlibs
>> #Requires: SUNWcairo
>> Requires: SUNWfontconfig
>> Requires: SUNWntfsprogs
>> Requires: SUNWdesktop-cache
>>
>
> Why do you have commented dependencies there?
>
>
>> %prep
>> %setup -q -c -n %name-%version
>> cd gparted-%{version}
>> %patch1 -p1
>> cd ..
>>
>> %build
>> cd gparted-%{version}
>> %if %cc_is_gcc
>> %else
>> export CXX="${CXX} -norunpath"
>> %endif
>> ./configure --prefix=/usr
>> make
>> cd ..
>>
>
> You should set CFLAGS and/or CXXFLAGS before ./configure
> so that compiler optimisation flags are set.
>
> Laca
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20091029/d97510fc/attachment.html>
