For clarification: the "-Wignore::DeprecationWarning" argument passed when invoking /usr/bin/python2.6 is necessary to suppress deprecation warnings. time-slider-0.2.10 uses os.popen4() and the popen2 which are both deprecated and replaced by the subprocess module. 0.2.10 is not the latest version of the time-slider code and the upstream code (which has significant rewrites) uses the subprocess module exclusively. Porting time-slider-0.2.10 to use the subprocess module would introduce more throw away code and unnecessary risk.
Thanks, Niall. Niall Power wrote: > Hi, > > Please review the following changes to make time-slider use python 2.6 > instead of python 2.4 (or the "python" environment variable). > > Cheers, > Niall. > > Diffs to time-slider-0.2.10 are attached. > > Diffs to SUNWgnome-time-slider.spec: > > Index: core/SUNWgnome-time-slider.spec > =================================================================== > --- core/SUNWgnome-time-slider.spec (revision 1089) > +++ core/SUNWgnome-time-slider.spec (working copy) > @@ -18,16 +18,17 @@ > Name: SUNWgnome-time-slider > Summary: Time Slider ZFS snapshot management for GNOME > Version: 0.2.10 > -Source: > http://dlc.sun.com/osol/jds/downloads/extras/time-slider/time-slider-%{version}.tar.bz2 > > > +Source: > http://dlc.sun.com/osol/jds/downloads/extras/time-slider/time-slider-%{version}.tar.bz2 > > > +Patch1: time-slider-01-python26.diff > SUNW_BaseDir: %{_basedir} > SUNW_Copyright: %{name}.copyright > BuildRoot: %{_tmppath}/%{name}-%{version}-build > > %include default-depend.inc > -BuildRequires: SUNWgnome-python-libs-devel > +BuildRequires: SUNWgnome-python26-libs-devel > BuildRequires: SUNWgksu-devel > -Requires: SUNWPython > -Requires: SUNWgnome-python-libs > +Requires: SUNWPython26 > +Requires: SUNWgnome-python26-libs > Requires: SUNWgksu > Requires: SUNWzfs-auto-snapshot > Requires: SUNWgnome-dialog > @@ -49,12 +50,13 @@ > > %prep > %setup -q -n time-slider-%{version} > +%patch1 -p1 > > %build > make > > %install > -export PYTHON="/usr/bin/python2.4" > +export PYTHON="/usr/bin/python2.6" > rm -rf $RPM_BUILD_ROOT > make install DESTDIR=$RPM_BUILD_ROOT > > @@ -128,6 +130,9 @@ > %endif > > %changelog > +* Wed Dec 09 2009 - niall.power at sun.com > +- Add patch time-slider-01-python26.diff and update > + BuildRequires and Requires python deps to python26 variants. > * Mon Nov 23 2009 - niall.power at sun.com > - Revert to previous version (0.2.10) until removed features > reimplemented or ARC review approved. Backs out prev. commit > >
