So the patch is now looks like:

$ svn diff SUNWvirt-manager.spec
Index: SUNWvirt-manager.spec
===================================================================
--- SUNWvirt-manager.spec    (revision 20450)
+++ SUNWvirt-manager.spec    (working copy)
@@ -32,7 +32,10 @@
 Requires: SUNWvirtinst
 Requires: SUNWurlgrabber
 Requires: SUNWdesktop-cache
+Requires: SUNWgtk-vnc
+Requires: SUNWgtk-vnc-python24
 Requires: %{name}-root
+BuildRequires: SUNWgtk-vnc-devel
 BuildRequires: SUNWgnome-python-libs-devel
 
 %package root
@@ -61,6 +64,7 @@
 
 %build
 cd %{name}-%{version}
+export PYTHON=/usr/bin/python%{pythonver}
 %virtmanager.build
 

-Ghee

Ghee Teo wrote:
> On 14/01/2010 04:33 AM, Halton Huo wrote:
>> Ghee,
>>
>> Is virt-manager still using self-bundled gtk-vnc?
>>    
> No. It doesn't use its own copy,
>
> gheet at osol-127-liveCD:~$ ps -fe | grep 20751
>    gheet 20784 20737   0 10:39:37 pts/1       0:00 grep 20751
>     root 20751     1   0 10:36:56 ?           0:02 python2.4 
> /usr/share/virt-manager/virt-manager.py
> gheet at osol-127-liveCD:~$ pfexec pldd 20751 | grep vnc
> /usr/lib/python2.4/vendor-packages/gtkvnc.so
> /usr/lib/libgtk-vnc-1.0.so.0.0.1
>
>> If no, I think you should add
>>
>> Requires:SUNWgtk-vnc
>> Requires:SUNWgtk-vnc-python24
>> BuildRequires:SUNWgtk-vnc-devel
>>
>>    
> Okay. I will add that in, Thanks for spotting.
>
> -Ghee
>> -Halton
>>
>> On Wed, 2010-01-13 at 22:11 +0000, Ghee Teo wrote:
>>   
>>> The bug http://defect.opensolaris.org/bz/show_bug.cgi?id=13826
>>> is because the build machine has now default to have python 2.6.
>>> Since vir-manager is still a python 2.4 ap, the share lib sparkline.so
>>> must also be compiled with python 2.4.
>>>
>>> So the patch is to make sure that
>>> PYTHON is defined to pick up the correction version 2,4 in this case.
>>>
>>>
>>>
>>>
>>> $ svn diff SUNWvirt-manager.spec
>>> Index: SUNWvirt-manager.spec
>>> ===================================================================
>>> --- SUNWvirt-manager.spec    (revision 20450)
>>> +++ SUNWvirt-manager.spec    (working copy)
>>> @@ -61,6 +61,7 @@
>>>
>>>   %build
>>>   cd %{name}-%{version}
>>> +export PYTHON=/usr/bin/python%{pythonver}
>>>   %virtmanager.build
>>>
>>>
>>> -Ghee
>>>      
>>
>>    
>

Reply via email to