For the gnome-2-28 branch:
- gdm-34-pam.diff:
This patch fixes a typo discovered in the review of GNOME bugzilla
bug #602403. Replacing the "=" with an "==" in the if-test should
be an obvious correct fix.
- gdm-36-no-click-login.diff: This is a more elegant patch for making
GDM start the PAM conversation immediately when the face browser is
turned off. The previous fix had several issues:
- The entry field did not have focus by default so the user needed
to click on the entry field to enter their username.
- The Shutdown/Restart buttons would never show up when the face
browser was off. Now they properly appear in the dialog.
- Simulating a mouse click was a hacky solution and this is just
a cleaner solution that is less likely to have unintended side
effects.
Both issues are fixed in the updated patch.
Patches for GDM head:
- gdm-24-pam.diff: Fixes the same issue highlighted above. Note that
this patch just fixes the equal sign issue since the gnome-2-28
version of the patch already went upstream into the 2.28.5 version
with this bug.
- gdm-21-no-click-login.diff: Again, fixes the same issue as highlighted
above. But the code in the 2.28 branch is quite a bit different.
Namely the Shutdown/Restart buttons were moved to the panel in GDM
2.29, so the code to deal with those buttons is not needed in this
version of the patch.
Brian
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gdm-21-no-click-login.diff
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20100115/251f756d/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gdm-23-pam.diff
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20100115/251f756d/attachment-0001.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gdm-34-pam.diff
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20100115/251f756d/attachment-0002.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gdm-36-no-click-login.diff
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20100115/251f756d/attachment-0003.ksh>
