I reworked the patch to fix CR #6915777 together. On Tue, 2010-02-09 at 15:26 -0600, Brian Cameron wrote: > Note bugster bug #6915777. This bug complains that GDM is calling > chmod/setfacl on /dev/audio and /dev/audioctl even on systems that do > not have such a device. > > I think that if you are fixing this code anyway, it would be good if > you > could also add some g_stat() calls to verify that the file exists, and > only call chmod/setfacl if the file exists. I use g_file_test instead, should be no different.
To keep code cleaner, I only check the existence of device audio (/dev/audio). I suppose the ctl device exists along with the device audio. > > So, can you go ahead and also fix this related bug as well? The bug > is currently assigned to me, but you can reassign it to yourself. -------------- next part -------------- A non-text attachment was scrubbed... Name: gdm-14-setfacl.diff Type: text/x-patch Size: 5107 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20100210/e62e9ef4/attachment.bin>
