On 19/10/11 12:17, Andy Seaborne wrote:
On 18/10/11 23:16, Damian Steer wrote:

On 18 Oct 2011, at 11:36, Andy Seaborne wrote:

On 17/10/11 23:09, Damian Steer wrote:

On 17 Oct 2011, at 22:33, Ian Dickinson wrote:

On 17/10/11 22:12, Damian Steer wrote:
Any objections to me adding this to jena?
No objection. I would +1, but given the framing of the question I
suspect I'd be objecting :)

Ian


What could be clearer than a hearty -1 of agreement ;-)

Damian

I agree that adding it would be good (whether that is +1, -1 or -i !)

Andy

Added, with tests derived from SAX2RDF.

Damian

StAX2SAX requires Java6 for javax.xml.stream.events.* This is the straw.

I'll reset the checked-in Eclipse settings to be compatible and start
updating all the other projects.


I get 3 warnings in Eclipse in StAX2SAX. Having a warnign free codebase
is really helpful to a release manager.


In Eclipse, I see 2732 warnings - all but 136 are missing @Override on
interfaces (I'm not sure what the standard Eclipse settings are). Does
anyone mind if I go and fix these and set the compiler level to warn on
missing @Override for interface implementations?

Eclipse "quick fix" wasn't perfect for fixing missing @Overrides all in one go. Nearly, but not quite.

There are just 4 non-missing @Override warnings in the codebase.

I'll commit the code with @Override (378 files) and with the Java level as environment "JavaSE-1.6". As it's one update, we can reverse it.

        Andy


Andy



Reply via email to