[
https://issues.apache.org/jira/browse/JENA-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149360#comment-13149360
]
Andy Seaborne commented on JENA-162:
------------------------------------
Rob - thanks for the patch.
A dataset description can also come from the protocol (?default-graph-uri and
?named -graph-uri) and these override anything in the query. So the concept of
"dataset description" needs to be a first class concept and not a bit of a
muddle as present. The QueryExecution context would be the place to put a
protocol (and we can interpret "protocol" widely e.g. command line) defined
description.
I think it's better if whether to accept or reject queries involving a dataset
description is pushed down to the storage layer. Then, rather than command
line options, it's a feature of the storage configuration.
I've added (actually, enabled unfinished code for) a DatasetDescription to ARQ
and a context key as preparation and made SDB explicitly reject requests with a
DatasetDescription (query or context).
As a temporary measure while we work out the details around this, I've made
Fuseki not test for a query dataset description if it's a TDB dataset.
Maybe there will need to be a command line argument -- let's work out how
ARQ/TDB/Fuseki treat dataset descriptions as a matter of principle and see.
> Add FROM/FROM NAMED support to Fuseki
> -------------------------------------
>
> Key: JENA-162
> URL: https://issues.apache.org/jira/browse/JENA-162
> Project: Jena
> Issue Type: New Feature
> Components: Fuseki
> Affects Versions: Fuseki 0.2.1
> Reporter: Rob Vesse
> Labels: from, from-named, sparql
> Attachments: FusekiFromSupport.patch
>
>
> Fuseki currently does not support FROM/FROM NAMED clauses returning a HTTP
> 400 error if a user tries to make use of them
> The attached patch provides for optional enabling of this feature by a user
> specified --from or --allowFrom switch when the server is started or
> programmtically via ARQ.getContext().set(Fuseki.enableFromClauses, true).
> Therefore unless a user turns this feature on by default the old behavior
> remains in place.
> When enabled Fuseki will not reject queries with FROM/FROM NAMED in them and
> will use DynamicDatasets.dynamicDataset() to build the dataset for queries,
> there is minimal overhead for queries without FROM/FROM NAMED clauses as the
> code in DynamicDatasets appears to leave the default dataset unchanged if no
> dataset description is present in the query AFAICT
> A small number of tests has been added to TestQuery.java to test the
> behaviour, more tests might be desirable and I can probably supply those if
> necessary but the ones given test all the obvious combinations with the
> trivial test data used by TestQuery
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
